Add ability to enumerate monitoring team options in config #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnnrj
force-pushed
the
PROD-2927-enumerate-monitoring-teams
branch
from
dd6f772 to
6bd54ea
Compare
|
Pushed change to take team enumeration out of config, and instead record a path to a file where the teams are stored. |
tmccombs
requested changes
Jan 16, 2025
admin/app/com/lucidchart/piezo/admin/controllers/TriggerFormHelper.scala
Outdated
Show resolved
Hide resolved
admin/app/com/lucidchart/piezo/admin/controllers/TriggerFormHelper.scala
Outdated
Show resolved
Hide resolved
admin/app/com/lucidchart/piezo/admin/models/MonitoringTeams.scala
Outdated
Show resolved
Hide resolved
admin/app/com/lucidchart/piezo/admin/models/MonitoringTeams.scala
Outdated
Show resolved
Hide resolved
admin/app/com/lucidchart/piezo/admin/models/MonitoringTeams.scala
Outdated
Show resolved
Hide resolved
admin/app/com/lucidchart/piezo/admin/models/MonitoringTeams.scala
Outdated
Show resolved
Hide resolved
|
Addressed all feedback: 7104fb7 Ready for another review |
tmccombs
reviewed
Jan 17, 2025
admin/app/com/lucidchart/piezo/admin/controllers/TriggerFormHelper.scala
Show resolved
Hide resolved
tmccombs
reviewed
Jan 17, 2025
admin/app/com/lucidchart/piezo/admin/controllers/TriggerFormHelper.scala
Show resolved
Hide resolved
tmccombs
approved these changes
Jan 17, 2025
hunterrees
requested changes
Jan 17, 2025
hunterrees
approved these changes
Jan 17, 2025
…umerated in a local file
tnnrj
force-pushed
the
PROD-2927-enumerate-monitoring-teams
branch
from
7104fb7 to
d558507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally adds the ability to provide a list of teams in config. If provided, the freeform "Monitoring team" field on a trigger will change to a required dropdown. Monitoring fields will also be hidden when monitoring priority is Off.
This will allow us to enforce team ownership of job triggers (if monitoring is on).
A future change will set the list of teams on each jobs host in chef. Piezo's behavior is unchanged if there are no teams set in config, so this is fully backwards compatible.
If the team field has a value that is not in the list of valid teams once it's added, a valid team must be selected the next time the trigger is edited.